Improve error handling for missing source files #18229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise `InvalidSourceList` error if new source file is not found Fixes python#18111
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
a test would be good here |
Contributor
Author
|
Based on the existing test cases, particularly (in It appears that the behavior of ignoring a nonexistent file after caching the previous result is intentional? (Please let me know if my understanding of this test case is correct.) This could be why some tests are currently failing. Additionally, if the change proposed in this PR is appropriate, we may need to modify many existing test data to align with the new behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise
InvalidSourceListerror if new source file is not found.dmypynow correctly reflects the absence of non-existent files, which was previously not reported.Fixes #18111
Testing
I manually tested the changes and confirmed that
dmypynow correctly reports errors when attempting to check non-existent files:I haven't added tests yet, as I'm still familiarizing myself with the testing framework used in the project. If this change is deemed appropriate, I will add the necessary test cases soon to ensure it is thoroughly validated.
I’m eager to contribute further and ensure this fix is robust. Thank you for your support and feedback!